Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QsForm Extractor for Actix #93

Closed
wants to merge 6 commits into from
Closed

Conversation

nMessage
Copy link
Contributor

Adds QsForm Extractor for Actix-web so that web forms can support arrays and other features of serde_qs

Resolves #52 using code provided by rapodaca

Added QsForm to support application/x-www-form-urlencoded Web forms
Added Into_inner function for both QsQuery and QsForm to behave like actix_webs default extractors
Made some fixes
Added new trait "IntoInner"
Fixed QsFormConfig not correctly setting new settings correctly
@silverpill
Copy link

Very nice, thank you for preparing this pull request.

QsForm works as expected. I have one suggestion though: implement into_inner() directly on QsForm. The requirement to import IntoInner trait feels unnecessary.

Removed trait requirement for using into_inner() now functions as a function.
src/actix.rs Outdated Show resolved Hide resolved
@samscott89
Copy link
Owner

Thanks for the submission @nMessage

I had a couple of small tweaks:

  • QsQueryConfig didn't need to be duplicated
  • Added some tests

Otherwise, it was looking good. Thanks for doing this. Merging this in #98

@samscott89 samscott89 closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to parse body?
3 participants