Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup fails for new email addresses via shortcode #91

Open
tedmsuperstar opened this issue Dec 15, 2020 · 0 comments
Open

Signup fails for new email addresses via shortcode #91

tedmsuperstar opened this issue Dec 15, 2020 · 0 comments

Comments

@tedmsuperstar
Copy link

When I try to sign up through the shortcode with a new email address, the list is updated on the sailthru side, but the server throws a 500 and the user doesn't see a "Thank You" message.

$profile is initialized as a boolean here https://github.com/sailthru/sailthru-wordpress-plugin/blob/master/widget.subscribe.php#L377

For a new email address, an error will be tried/caught here: https://github.com/sailthru/sailthru-wordpress-plugin/blob/master/widget.subscribe.php#L380

So far, $profile is still set to false.

We pass $profile into a function here https://github.com/sailthru/sailthru-wordpress-plugin/blob/master/widget.subscribe.php#L429

That function's signature requires $profile to be an array, not a bool here: https://github.com/sailthru/sailthru-wordpress-plugin/blob/master/widget.subscribe.php#L429

And we get a 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant