Feature request: Extract HTTP logic into a new class

[rossmotley]

I think it would be a good thing to extract the following two methods into a new $transport object, which implements some sort of interface:

\Sailthru_Client::httpRequestCurl
\Sailthru_Client::httpRequestWithoutCurl

This will make it easier to:

• Unit test the Sailthru_Client class without resorting to partial mocks
• Add logging or other implementations (Guzzle? Buzz?)

We could provide two implementations in this codebase, curl and streams, which don't have any other dependencies.

The interface could potentially make use of the PSR7:

http://www.php-fig.org/psr/psr-7/

[djmarland]

+1
Without this we currently have issues as we need to set proxies, and there is no way to inject a curl_setopt($ch, CURLOPT_PROXY, $proxy); as it currently stands

[silverman63]

Hi all, as this is a bigger update, I can start to explore it, but can't put in this upcoming release. I'll look at our other clients that have HTTP broken out. Will reference the ticket + CC you both in the PR when we get there. @rossmotley will also look at the sketch in your fork.