Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers wanted #173

Open
Etiene opened this issue Sep 24, 2018 · 9 comments
Open

Maintainers wanted #173

Etiene opened this issue Sep 24, 2018 · 9 comments

Comments

@Etiene
Copy link
Member

Etiene commented Sep 24, 2018

Sailor has been almost abandoned for almost two years now because I didn't have time and I had to move on to other projects due to MSc and work. There were some people offering help, but in the end nothing happened. Anyone else would like to take over? Happy to mentor and offer some guidelines of next milestones

@jperon
Copy link
Contributor

jperon commented Sep 27, 2018

Sailor has been abandoned for almost two years now because I didn't have time

What a pity : I've just discovered it, and it's great !

Helping is something I can do (for bugfixes or small enhancements), but I don't have enough skills to take over.

@Etiene
Copy link
Member Author

Etiene commented Oct 1, 2018

I am still revieweing pull requests :)

@Immortalin
Copy link

I just put the word out. Hopefully someone will step up!

@jayluxferro
Copy link

Hi, I just came across it and I think its really cool. I would love to maintain it. Will need some guidelines though. Thank you.

Sailor has been almost abandoned for almost two years now because I didn't have time and I had to move on to other projects due to MSc and work. There were some people offering help, but in the end nothing happened. Anyone else would like to take over? Happy to mentor and offer some guidelines of next milestones

@Etiene
Copy link
Member Author

Etiene commented Nov 7, 2018

Thanks @Immortalin for announcing this!

@jayluxferro please send me an email at dalcol@etiene.net and lets chat and I can guide you through the project :)

@Etiene
Copy link
Member Author

Etiene commented Nov 27, 2018

I sent an email to @jayluxferro, but realized why not post some of my considerations in public too:

Important questions to have in mind:

  • Are there other Lua web frameworks with the same proposition as Sailor? Is it worth keeping Sailor maintenance or is it better to contribute to another project?
  • Is Sailor the best proposition for web development in the Lua world today? How did the web development in other languages evolve?
  • What are new technologies for using Lua on web? How can Sailor leverage those?
  • What mistakes were made during the development of Sailor that now need fixing?

And here are some of my thoughts about some of these questions and the current state of the project:

  • 1 - In my experience with the project so far, there were a few mistakes made in how many webservers it supports. A lot of people contributed with compatibility with different servers and then never maintained it, leaving bugs for me and @felipedaragon to fix, making it very hard for us to keep. Also, at the time, apache had lua support through an extension called mod_lua that was included at the apache installation, and the whole library for using sailor with other servers made abstractions considering compatibility with what was defined by this extension. Nowadays, this extension is no longer maintained or included by default in apache installations, making it very cumbersome to use it. In the meantime, Lua on nginx has progressed wonderfully with Openresty. In my opinion, this whole part should be redesigned thinking of nginx as the default and having just one other pure lua web server for local dev environment. This brings sailor, however, very close to lapis (http://leafo.net/lapis/). And makes me think if it's even worth considering pursuing Sailor. What do you think about this?

  • 2 - Another past mistake is how closely connected some of the sailor inner libraries are. Ideally, everything should be like valua and easily usable on its own. These libraries should be part of sailor as an "extension" or "plugin", whatever it's called. I think creating a feature that allows this would greatly improve the framework and its maintenance.

I have some other thoughts considering the use of lua at frontend development, but I think this has less priority as long as Sailor is good at returning JSON, so I'm not gonna dwelve into this part yet.

Looking forward to hearing your thoughts!

@elihugarret
Copy link

Hi Etiene!

About the questions above:

"Are there other Lua web frameworks with the same proposition as Sailor? Is it worth keeping Sailor maintenance or is it better to contribute to another project?"

I dont know about others MVC like Lua frameworks out there but will be great to keep Sailor and push forward. I agree that the default server should be nginx and limit the servers it supports (may be looking forward to containarization), even if it is too close to Lapis for sharing the Openresyiness, the most important difference is that Lapis is Moonscript oriented and the language hasnt received updates recently and Lua is improving constantly. I've been experimenting with the two frameworks and sometimes Lapis feels like Flask in the sense that I feel more confortable writing APIs in it and Sailor is like an all-terrain framework.

Is Sailor the best proposition for web development in the Lua world today? How did the web development in other languages evolve?

Sailor is/was the more friendly for web development in the Lua ecosystem. I never managed to deploy it to Heroku, but Alwaysdata gives full support and dont know about any other Lua web framework that can be so easily hosted.

"What are new technologies for using Lua on web? How can Sailor leverage those?"

I think there´s more focus on "Lua on the front-end". Fengari is super interesting and easy to make things with it, also it integrates very well with Hyperapp, I 've made an example here. Maybe providing Sailor with a Lua modern front-end framework (components, state management, etc) will boost more its coolness. I dont know if it is ok to continue to include Starlight, it was pretty awesome but seems that it is no longer maintained.

The modularization of the point number 2 may be the next step needed for adding new features. I've tried to implement hot-swapping in the controller but I failed cause the inner libs are very connected.

It would be nice to maintain Sailor, and contribute to the Lua community in this way besides making strange noises with computers :) I'll need to know the guidelines and maybe discuss about making a Roadmap.

@Etiene
Copy link
Member Author

Etiene commented Dec 5, 2018

I guess then the best decision is, if anyone has time to tackle the modularization (which is the only thing that can open new doors for the future of sailor), then the project should keep going, otherwise it should be archived. Anyone can tackle this?

@malachaifrazier
Copy link

I'm kinda new-ish and just now starting to dig into the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants