New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install_crate
dependencies not installing if newer version is already installed
#1062
Comments
explicitly setting |
either do:
or:
which are the currently supported formats. you can see the types.rs for what combinations are supported. |
also i do'nt think the doc link you gave shows combination as you suggested, maybe i'm wrong. but if something is not clear, would love you to help clear it up in the docs. |
@sagiegurari Even when I switch this to |
i ran: cargo install cargo-expand checked version manuallly: gitpod /workspace/cargo-make (master) $ cargo expand --version
cargo-expand 1.0.81 created this makefile: [config]
skip_core_tasks = true
skip_git_env_info = true
skip_rust_env_info = true
skip_crate_env_info = true
[tasks.default]
install_crate = { crate_name = "cargo-expand", binary="cargo", test_arg=["expand", "--version"], version = "1.0.80" }
script = '''
cargo expand --version
''' ran it:
works fine. |
install_crate
dependencies not installing if older version is already installedinstall_crate
dependencies not installing if newer version is already installed
@sagiegurari I am able to repro your behavior, but i still see other cases where this is not functioning. Ex. If i enable core tasks and extend the
As you see above, when cargo-expand is already installed, it does not force the installation of the older version. But when uninstall cargo-expand and rerun the task, it works:
It seems like it is failing to respect |
@wmmc88 ok got it.
same goes for version, not just in version. [tasks.test]
description = "Runs all available tests."
category = "Test"
install_crate = false
toolchain = "${CARGO_MAKE_RUST_DEFAULT_TOOLCHAIN}"
command = "cargo"
args = [
"test",
"@@remove-empty(CARGO_MAKE_CARGO_VERBOSE_FLAGS)",
"@@split(CARGO_MAKE_CARGO_BUILD_TEST_FLAGS, )",
] since toolchain is defined, you won't have support for min/version here. options
|
@wmmc88 closing but reopen if you feel something is missing |
Describe The Bug
When
install_crate
is declared withversion
, and a different version is present on the system, cargo-make will not install the specified version. This is contrary to what's state in the documentation.To Reproduce
The text was updated successfully, but these errors were encountered: