Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace cargo test with cargo nextest run for better performance & test summary report #1014

Open
ben1009 opened this issue Jan 5, 2024 · 4 comments

Comments

@ben1009
Copy link
Contributor

ben1009 commented Jan 5, 2024

Feature Description

as the title

Describe The Solution You'd Like

Code Sample

/// paste code here
@sagiegurari
Copy link
Owner

@ben1009 interesting idea, but why replace it by default and not in your extended makefile?

the original test task is defined as follows:

[tasks.test]
description = "Runs all available tests."
category = "Test"
install_crate = false
toolchain = "${CARGO_MAKE_RUST_DEFAULT_TOOLCHAIN}"
command = "cargo"
args = [
  "test",
  "@@remove-empty(CARGO_MAKE_CARGO_VERBOSE_FLAGS)",
  "@@split(CARGO_MAKE_CARGO_BUILD_TEST_FLAGS, )",
]

you can replace the command arguments to something else (just the delta) for example in your makefile add:

[tasks.test]
args = ["nextest", "run"]

and it should work i think.

@ben1009
Copy link
Contributor Author

ben1009 commented Jan 16, 2024

@ben1009 interesting idea, but why replace it by default and not in your extended makefile?

the original test task is defined as follows:

[tasks.test]
description = "Runs all available tests."
category = "Test"
install_crate = false
toolchain = "${CARGO_MAKE_RUST_DEFAULT_TOOLCHAIN}"
command = "cargo"
args = [
  "test",
  "@@remove-empty(CARGO_MAKE_CARGO_VERBOSE_FLAGS)",
  "@@split(CARGO_MAKE_CARGO_BUILD_TEST_FLAGS, )",
]

you can replace the command arguments to something else (just the delta) for example in your makefile add:

[tasks.test]
args = ["nextest", "run"]

and it should work i think.

yes, but what i means is from contributor's perspective. The test results from cargo test is not easy to read, besides some tests seems fail always. Not sure it's expected or not https://github.com/sagiegurari/cargo-make/actions/runs/7537960284/job/20517689511#step:5:5189

@sagiegurari
Copy link
Owner

oh, you mean replace cargo-make own tests, not the general built in test task in the internal makefile?

@ben1009
Copy link
Contributor Author

ben1009 commented Jan 17, 2024

oh, you mean replace cargo-make own tests, not the general built in test task in the internal makefile?

yes, the one triggered by cargo make ci-flow in ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants