Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api kit] Update delegates endpoint to v2 #804

Merged
merged 20 commits into from May 10, 2024
Merged

[api kit] Update delegates endpoint to v2 #804

merged 20 commits into from May 10, 2024

Conversation

leonardotc
Copy link
Contributor

What it solves

Resolves #786

How this PR fixes it

  • Updates the endpoints to use V2.
  • Change any necessary that for that.
  • Change the signing to work in tandem with eip712.

@leonardotc leonardotc self-assigned this May 3, 2024
@coveralls
Copy link

coveralls commented May 6, 2024 •
edited

Pull Request Test Coverage Report for Build 9013323948

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 78.584%
Totals Coverage Status
Change from base Build 8983003158: -0.2%
Covered Lines: 711
Relevant Lines: 845
💛 - Coveralls

@leonardotc
Copy link
Contributor Author

I had to use this endpoint on the e2e tests: https://safe-transaction-sepolia.staging.5afe.dev/api

@leonardotc leonardotc linked an issue May 6, 2024 that may be closed by this pull request
[api-kit] Update delegates endpoint #786
Closed
yagopv
yagopv reviewed May 9, 2024
View reviewed changes
packages/api-kit/src/SafeApiKit.ts
const data = delegate + totp
const signature = await signer.signMessage(data)
const signature = await signDelegate(signer, delegate, this.#chainId)

const body: any = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is SafeDelegateResponse right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const body: any = {
const body: SafeDelegateResponse = {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is the request body which is marked as any on the type.

@leonardotc leonardotc merged commit 8cf4bf8 into development May 10, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@dasanra dasanra deleted the feat/api-kit/update-delegates-endpoint branch May 15, 2024 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yagopv yagopv yagopv approved these changes

Assignees

@leonardotc leonardotc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[api-kit] Update delegates endpoint
3 participants
@leonardotc @coveralls @yagopv