Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4337] Use and test 0.7 entrypoint #776

Open
dasanra opened this issue Apr 15, 2024 · 0 comments
Open

[4337] Use and test 0.7 entrypoint #776

dasanra opened this issue Apr 15, 2024 · 0 comments
Assignees

Comments

@dasanra
Copy link
Collaborator

dasanra commented Apr 15, 2024

Context / issue

0.7 entrypoint was unfinished when we started 4337 implementation. Currently it seems ready to be used and it should be possible to use it with the Safe SDK. We need to test and support both versions in the SDK.

Proposed solution

  • Update the safe-modules-deploymentsto the latest version, having compatibility for 0.2.0 or 0.3.0 versions of the Safe module.
  • We should keep 0.6 entrypoint by default (which is supported by 0.2.0 version of the Safe module). The API is not supporting v0.7 UserOperations yet.
  • From the supported entrypoints we receive from the bundler we need to detect which one is 0.6 or 0.7.
  • When we load a Safe that is already deployed, the SDK needs to be able to select the correct module that the Safe is using.
  • AddModulesLib was renamed to SafeModuleSetup. Everything will still work if unchanged, but would be good to align naming convention to avoid future breaking changes.
  • Add tests that ensure we support both versions.

Additional context

safe-modules CHANGELOG

The API service won't be compatible with 0.7.0 yet. We can add compatibility to the SDK setting the specific module address manually. We should test this approach to anticipate the differences in the SafeOperation object.

For this ticket it's expected just to test setting the module to 0.3.0 manually passing the address.

@dasanra dasanra changed the title [4337] Test 0.7 entrypoint [4337] Use and test 0.7 entrypoint by default Apr 15, 2024
@dasanra dasanra changed the title [4337] Use and test 0.7 entrypoint by default [4337] Use and test 0.7 entrypoint Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants