Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Vulnerability #698

Open
DmytroShalaiev opened this issue Feb 15, 2024 · 12 comments
Open

Package Vulnerability #698

DmytroShalaiev opened this issue Feb 15, 2024 · 12 comments

Comments

@DmytroShalaiev
Copy link

Снимок экрана 2024-02-15 в 14 50 07

tough-cookie (package.json) 2.5.0 .
CVE-2023-26136 https://avd.aquasec.com/nvd/cve-2023-26136
tough-cookie: prototype pollution in cookie memstore,

Fixed in 4.1.3

@dasanra
Copy link
Collaborator

dasanra commented Feb 15, 2024

Thank you for your report.

We are currently working to remove web3 v1 dependency that will get rid of those unmaintained libs. In any case the protocol-kit is not affected as it doesn't make use of the Swarm network.

@DmytroShalaiev
Copy link
Author

Thanks

@andrewkmin
Copy link

andrewkmin commented Mar 27, 2024

Hi there, any update on moving off of web3 v1? There is a vulnerability in web3-utils < v4.2.1. However, here's the dependency tree:

@safe-global/protocol-kit@3.0.1 > web3@1.10.4 > web3-core@1.10.4 > web3-core-helpers@1.10.4 > web3-eth-iban@1.10.4 > web3-utils@1.10.4

meaning typechecks would fail with this combination of versions.

Would appreciate an update, thanks!

@dasanra
Copy link
Collaborator

dasanra commented Apr 2, 2024

@andrewkmin Thank you for sharing this. It will be our main focus until we get rid of it.

@DmytroShalaiev
Copy link
Author

Hello, are there any updates?

@dasanra
Copy link
Collaborator

dasanra commented Apr 24, 2024

@DmytroShalaiev we are currently working on a big refactor in which we will get rid of web3 v1

#770

@DmytroShalaiev
Copy link
Author

Thanks I will follow updates

@DmytroShalaiev
Copy link
Author

@dasanra #770 merged, is it already released? If yes - new tags are still vulnerable. If no - maybe you can share ~ due date.

@dasanra
Copy link
Collaborator

dasanra commented May 16, 2024

@DmytroShalaiev we are preparing the release yet, we will publish the new version soon. There will be breaking changes affecting some of the kits, we are finishing the migration guides before publishing.

@DmytroShalaiev
Copy link
Author

Thanks, will be waiting

@dasanra
Copy link
Collaborator

dasanra commented May 22, 2024

@DmytroShalaiev latest published version should solve all the mentioned vulnerabilities

https://github.com/safe-global/safe-core-sdk/releases/tag/r40

@DmytroShalaiev
Copy link
Author

Thanks I will upgrade and check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants