Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeFactory for custom chainId throws the error: SafeProxy was not deployed correctly. #650

Open
ashwinYardi opened this issue Jan 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ashwinYardi
Copy link

Description

When you try to use SafeFactory with contractNetworks property for the custom chainId, safeFactory.deploySafe fails with an error: SafeProxy was not deployed correctly. If you check on-chain, Safe does get deployed correctly via SafeFactory.

This error is because, after the safe is created, protocol-kit listens to an event ProxyCreation. For osome reason, on custom networks, SDK cannot catch this event. But of you attach an independent event listener via ethers, then you can see the event being emmited correctly.

Environment

  • Safe Core SDK version: 2.0.0
  • Safe contract version: default
  • Environment: Non Browser

Steps to reproduce

Here is the code I am using:
image

Here is the error:
image

Expected result

Expected result is Safe creation should work normally as it works on other public networks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants