Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-kit): Add Viem adapter #665

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

feat(protocol-kit): Add Viem adapter #665

wants to merge 45 commits into from
+1,532 −11

Conversation

farreldarian
Copy link

What it solves

Resolves #594

How this PR fixes it

Created ViemAdapter

@farreldarian
Handle viem transaction receipt
36ae844
@farreldarian
Install viem
660dba6
@farreldarian
Create base SafeContractViem
d64192c
@farreldarian
Create adapter for Safe 1.4.1
b1d2a20
@farreldarian
Create adapter for Safe 1.3.0
7e0078f
@farreldarian
Add adapter for Safe 1.2.0
a7b12d0
@farreldarian
Create adapter for Safe 1.1.1
56cd73b
@farreldarian
Create adapter for safe 1.0.0
43dbfa6
@farreldarian
Create getSafeContractInstance
e4b5adf
@farreldarian
Initialize viem adapter
a6b0ccc
@farreldarian
Setup viem adapter in test
98baf7f
@farreldarian
Update test script
5e6ae31
@farreldarian
Extract to ClientPair
edd3683
@farreldarian
Create base SafeProxyFactoryContract
c2aeae8
@farreldarian
Implement all versions of SafeProxyFactoryContract
139fc53
@farreldarian
Add safeProxyFactory to adapter
7a085b6
@farreldarian
Implement isContractDeployed
62c92f9
@farreldarian
Implement getTransaction
01e8c50
@farreldarian
Implement get address
5964815
@farreldarian
Implement signMessage
f748a89
@farreldarian
Implement estimateGas
e979b63
@farreldarian
Implement call
e1b4c87
@farreldarian
Implement abidecoder
19e5f06
@farreldarian
Implement CompatibilityFallbackHandler adapter
cdac7bf
@farreldarian
Refactor to viem contract
7e4f1af
@farreldarian
Create multisend adapter
bb5fb67
@farreldarian
Create adapter for MultiSendCallOnly
f34014e
@farreldarian
Create adapter for createcall
8d7b087
@farreldarian
Create adapter for SignMessageLib
40d5fe5
@farreldarian
Create adapter for SimulateTxAccessor
03eb7f0
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2024 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@farreldarian farreldarian mentioned this pull request Jan 14, 2024
Open
@farreldarian
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@d4mr
Copy link

d4mr commented Feb 9, 2024

This will be great to have, anything pending to add, or anything we can do to help expedite this?

@farreldarian
Copy link
Author

Hi @d4mr, I hope to continue on this over the weekend, currently the tests are still failing. Additionally, I might need to check for any change from the AbiType migration (e.g. #673)

@farreldarian
Copy link
Author

Update: 10 test failing

     AbiFunctionNotFoundError: Function "isValidSignature(bytes32,bytes)" not found on ABI.
Make sure you are using the correct ABI and that the function exists on it.

Docs: https://viem.sh/docs/contract/encodeFunctionData.html
Version: viem@2.0.6
      at encodeFunctionData (/Users/farreldarian/code/safe-global/safe-core-sdk/node_modules/viem/utils/abi/encodeFunctionData.ts:92:22)
      at CompatibilityFallbackHandler_V1_4_1_Viem.encode (src/adapters/viem/ViemContract.ts:2:789)
      at Safe.isValidSignature (src/Safe.ts:41:17)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Context.<anonymous> (tests/e2e/eip1271-contract-signatures.test.ts:292:11)

Need to check on how to specify overloaded function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support viem
2 participants
@farreldarian @d4mr