Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove safe-contracts npm references #528

Open
dasanra opened this issue Sep 7, 2023 · 1 comment
Open

Remove safe-contracts npm references #528

dasanra opened this issue Sep 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dasanra
Copy link
Collaborator

dasanra commented Sep 7, 2023

Context / issue

Currently we are referencing safe-contracts npm package to get the smart contracts code to create types. The problem is that the protocol-kit needs to support several versions of the smart contracts at the same time, and fetching this npm packages produce dependencies inconsistencies that affect dependency management of the protocol-kit.

As these contracts are suposed not to be changed once compatible with the protocol kit, and also that they are only needed to generate types and execute tests, it's better that we reference or copy the necessary files directly.

Proposed solution

Copy the contract code to the protocol-kit repository of those versions that are final and stablished.

Alternatives

Sync with the protocol team if it could be possible to add types to safe-deployments or other helpers to enable the types and testing case on external projects.

@dasanra dasanra added the enhancement New feature or request label Sep 7, 2023
@mmv08
Copy link
Member

mmv08 commented Sep 7, 2023

Sync with the protocol team if it could be possible to add types to safe-deployments or other helpers to enable the types and testing case on external projects.

Release 1.5.0 will include types for ethers v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants