Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_ora using adata as the input #56

Open
biopzhang opened this issue Jul 11, 2023 · 2 comments
Open

run_ora using adata as the input #56

biopzhang opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@biopzhang
Copy link

Describe the bug
Using adata as input, if there is an empty sample (i.e., expression of the cell/sample is 0 for all genes), there will be an error writing the results to adata.obsm due to the deletion of the empty sample(s).

dc.run_ora(
mat=adata,
net=msigdb,
source='geneset',
target='genesymbol',
verbose=True,
use_raw=False
)

To Reproduce
As described above.

Expected behavior
As described above.

System

  • OS: [e.g. macOS Ventura]
  • Python version [e.g. 3.9]

Additional context
By any means, an empty sample should not be present in the data. However, as decoupler actively check for empty samples and genes and deletes them, for integrity, it might be reasonable to return the repaired adata with results.

@biopzhang biopzhang added the bug Something isn't working label Jul 11, 2023
@PauBadiaM
Copy link
Collaborator

Hi @biopzhang ,

Thanks for finding this out! Indeed it should, but its going to be hard to refactor the code to accommodate this. I'll keep it in mind but for now it's on low priority since it is an edge case and the user can always remove those cells beforehand.

@PauBadiaM PauBadiaM self-assigned this Jul 12, 2023
@biopzhang
Copy link
Author

Hi @biopzhang ,

Thanks for finding this out! Indeed it should, but its going to be hard to refactor the code to accommodate this. I'll keep it in mind but for now it's on low priority since it is an edge case and the user can always remove those cells beforehand.

Sounds reasonable to me. Thanks!

@gabora gabora added the enhancement New feature or request label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants