Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-loader v8+ compatibility #587

Open
Liwoj opened this issue Jan 18, 2020 · 0 comments
Open

sass-loader v8+ compatibility #587

Liwoj opened this issue Jan 18, 2020 · 0 comments

Comments

@Liwoj
Copy link

Liwoj commented Jan 18, 2020

Bug report

Including sass files while using sass-loader version 8+ throws error when compiling the app

ValidationError: Invalid options object. Sass Loader has been initialised using an options object that does not match the API schema. - options has an unknown property 'indentedSyntax'. These properties are valid: object { implementation?, sassOptions?, prependData?, sourceMap?, webpackImporter? } at validate

Reason is sass-loader introduced breaking change in 8.0 moving all sass options under sassOptions sub-key

Problematic file is config-css.js

Fix will be probably hard without introducing incompatibility with previous versions of sass-loader. Are you sure this option is actually necessary ? My understanding is both node-sass and dart-sass are able to switch between syntax based on file extension - indented for sass and non-indented for scss

Other problem I see is that in saber-config the build.loaderOptions.sass is used for both sass and scss configuration. It would be useful to have dedicated key just for scss

Steps to reproduce

What is expected?

What is actually happening?

Other relevant information

  • Result of running saber -v:
  • Browser version (optional):
  • Is Saber a global or local install?
  • Which package manager did you use for the install?
  • Does this issue occur when all plugins are disabled?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant