You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for this integration. Does the job perfectly, and setting up with my own API credentials was a breeze.
Going through logs I've noticed the integration logs the full user provided client_id and client_secret if Google responds with a http/401. This likely doesn't pose a security risk as such as the credentials are wrong, but I'd say it's safer to assume worst-case scenario and redact those details before logging the error.
03-10 11:21:02 ERROR Error serving GET http://<redacted>/manualauth?client_id=<this_is_logged>&client_secret=<this_is_logged>
03-10 11:21:02 ERROR
addon/backup/ui/uiserver.py:801 (error_middleware)
addon/backup/ui/uiserver.py:278 (manualauth)
addon/backup/drive/authcodequery.py:42 (requestCredentials)
backup.exceptions.exceptions.GoogleCredGenerateError: Google responded with error status HTTP 401. Please verify your credentials are set up correctly.
The text was updated successfully, but these errors were encountered:
Thank you for this integration. Does the job perfectly, and setting up with my own API credentials was a breeze.
Going through logs I've noticed the integration logs the full user provided
client_id
andclient_secret
if Google responds with a http/401. This likely doesn't pose a security risk as such as the credentials are wrong, but I'd say it's safer to assume worst-case scenario and redact those details before logging the error.The text was updated successfully, but these errors were encountered: