Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nikic/php-parser v5 #4247

Closed
kevin-appelt opened this issue Apr 23, 2024 · 2 comments
Closed

Allow nikic/php-parser v5 #4247

kevin-appelt opened this issue Apr 23, 2024 · 2 comments
Labels
Feature

Comments

@kevin-appelt
Copy link

The issue

TYPO3 Rector does block the update to the just released TYPO3 v13.1 due to dependency conflicts.

Composer error message

- Root composer.json requires ssch/typo3-rector 2.5.0 -> satisfiable by ssch/typo3-rector[v2.5.0].
- typo3/cms-install 13.2.x-dev is an alias of typo3/cms-install dev-main and thus requires it to be installed too.
- typo3/cms-install[dev-main, v13.1.0] require nikic/php-parser ^5.0.1 -> satisfiable by nikic/php-parser[v5.0.1, v5.0.2, 5.0.x-dev].
- Conclusion: don't install nikic/php-parser v5.0.2 (conflict analysis result)
- Root composer.json requires typo3/cms-install ^13.1 -> satisfiable by typo3/cms-install[v13.1.0, 13.2.x-dev (alias of dev-main)].

The dependency conflict

typo3/cms-install requires "nikic/php-parser": "^5.0.1"
ssch/typo3-rector requires "nikic/php-parser": "^4.18.0"

The solution

Allow installation of nikic/php-parser v5 (maybe in addition to v4 if needed/possible).

This might help somehow

Quickfix

Just in case someone stumbles across this issue as long as it is not resolved.
Removing TYPO3 Rector (for now) does allow installation of TYPO3 v13.1
@sabbelasichon
Copy link
Owner

sabbelasichon commented Apr 23, 2024 •
edited

@kevin-appelt Thanks for reporting it. We should rather make TYPO3 compatible for v4 and v5 of nikic/php-parser. The task should be much simpler.

dkd-kaehm added a commit to dkd-kaehm/typo3-rector that referenced this issue May 13, 2024
@dkd-kaehm
[TASK] Allow nikic/php-parser v5 for TYPO3 13.1.x compatibility
65d4b91 
Fixes: sabbelasichon#4247
@dkd-kaehm dkd-kaehm mentioned this issue May 13, 2024
Closed
@simonschaufi
Copy link
Collaborator

This is mostly blocked by Rector itself as Rector itself is not compatible with nikic/php-parser v5, see rectorphp/rector#8567

@sabbelasichon sabbelasichon reopened this May 24, 2024
@sabbelasichon sabbelasichon closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Allow nikic/php-parser v5 for TYPO3 13.1.x compatibility dkd-kaehm/typo3-rector
3 participants
@simonschaufi @sabbelasichon @kevin-appelt