Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Missing negation on SubstituteConstantsModeAndRequestTypeRector #4256

Closed
helsner opened this issue Apr 29, 2024 · 0 comments · Fixed by #4257 or #4278
Closed

[BUG] Missing negation on SubstituteConstantsModeAndRequestTypeRector #4256

helsner opened this issue Apr 29, 2024 · 0 comments · Fixed by #4257 or #4278
Labels
Bug

Comments

@helsner
Copy link
Collaborator

helsner commented Apr 29, 2024 •
edited by simonschaufi

Minimal PHP Code Causing Issue

if (TYPO3_MODE !== 'FE') {

Applied rules

SubstituteConstantsModeAndRequestTypeRector

Expected Behaviour

if (!ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])->isFrontend()) {
  // Do something
}

Package Version

main

PHP Version

8.1

TYPO3 Version

v11

Notes

No response
@helsner helsner added the Bug label Apr 29, 2024
helsner added a commit that referenced this issue Apr 29, 2024
@helsner
[BUGFIX] Add missing negate operator
96095b7 
Resolves: #4256
@helsner helsner mentioned this issue Apr 29, 2024
Merged
@simonschaufi simonschaufi changed the title [BUG]: Missing negation on SubstituteConstantsModeAndRequestTypeRector [BUG] Missing negation on SubstituteConstantsModeAndRequestTypeRector May 11, 2024
helsner added a commit that referenced this issue May 25, 2024
@helsner
[BUGFIX] Add missing negate operator
a39ddd6 
Resolves: #4256
helsner added a commit that referenced this issue May 25, 2024
@helsner
[BUGFIX] Add missing negate operator
6b3aa30 
Resolves: #4256
This was referenced May 25, 2024
Open
Merged
helsner added a commit that referenced this issue May 27, 2024
@helsner
[BUGFIX] Add missing negate operator
641cfe9 
Resolves: #4256
sabbelasichon pushed a commit that referenced this issue May 28, 2024
@helsner @sabbelasichon
[BUGFIX] Add missing negate operator
7b0d820 
Resolves: #4256
sabbelasichon pushed a commit that referenced this issue May 28, 2024
@helsner
[BUGFIX] Add missing negate operator (#4278)
0d60f62 
Resolves: #4256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
1 participant
@helsner