fix: update chromedriver download URL, resolve test issues #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things to get CI working for the repo again:
matches_cargo
accept both the old and new formats.macos-latest
default, the current geckodriver setup fails for that platform.It's not entirely obvious to me why at this point. Downgrading to theEdit: It seems like the only thing preventing macOS from working was that I needed to manually install Firefox. I'm guessing this was available in the previous macOS runners by default.macos-13
runner has these tests working again. This is probably the most.. questionable change as it'd be better to track down why the latest runners don't work.Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
Closes #1390