Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: separator gets folded by subsection #2362

Open
expikr opened this issue Apr 12, 2024 · 4 comments · Fixed by #2364
Open

Bug: separator gets folded by subsection #2362

expikr opened this issue Apr 12, 2024 · 4 comments · Fixed by #2364
Labels
A-Summary Area: The summary page, organization of pages. C-bug Category: A bug, incorrect or unintended behavior

Comments

@expikr
Copy link
Contributor

expikr commented Apr 12, 2024

0.4.37

# book.toml
output.html.fold.enable = true
<!-- SUMMARY.md -->
- [Chapter 1](./chapter_1.md)
- [Chapter 2](./chapter_2.md)
  - [Hidden Section](./hidden-section.md)

---

[Credits](./credits.md)

image

image

@ehuss ehuss added C-bug Category: A bug, incorrect or unintended behavior A-Summary Area: The summary page, organization of pages. labels Apr 13, 2024
@expikr
Copy link
Contributor Author

expikr commented Apr 15, 2024

The issue would be solved by moving the divider <li> onto the same level as chapter items rather than being nested under the immediately preceding section level.

I'd like to dig into this but can't figure out which part of the codebase populates the toc, if I can get a quick pointer then it'd greatly speed up the process.

@ehuss
Copy link
Contributor

ehuss commented Apr 15, 2024

The spacer is added to the TOC here. It's a bit tricky how that interacts with current_level. At a glance I'm not sure how that should be better organized.

@ehuss
Copy link
Contributor

ehuss commented Apr 19, 2024

Note, this is a duplicate of #733.

@expikr
Copy link
Contributor Author

expikr commented Apr 24, 2024

Turns out the fix is as simple as just moving the divider processing to the same spot as part titles, no change to the logic whatsoever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Summary Area: The summary page, organization of pages. C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants