Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific ligatures not working #2335

Open
Ciflire opened this issue Mar 11, 2024 · 5 comments
Open

Specific ligatures not working #2335

Ciflire opened this issue Mar 11, 2024 · 5 comments
Labels
C-bug Category: A bug, incorrect or unintended behavior

Comments

@Ciflire
Copy link

Ciflire commented Mar 11, 2024

Problem

In rust-by-practice code block i found that some ligatures of MonoLisa won't render and make the dots in ..= and .= invisible, where it should render like that
image

Steps

  1. Go on rust by practice
  2. Use monolisa font (or maybe some others)
  3. write ..= inside a code block

Possible Solution(s)

No response

Notes

it does work in monolisa playground and typst online editor, so i fugured it might come from here
It does render inside of code block, but not input code block

Version

Could not figure out from the github repo
@Ciflire Ciflire added the C-bug Category: A bug, incorrect or unintended behavior label Mar 11, 2024
@ehuss
Copy link
Contributor

ehuss commented Mar 11, 2024

Thanks for the report! I'm not sure what monalisa is, but the fonts are defined by the book's CSS. In particular, code blocks use "Source Code Pro", which is a different font. If you are overriding the fonts, you will need to make sure they are overridden for all places fonts are defined.

@Ciflire
Copy link
Author

Ciflire commented Mar 11, 2024

sry, monolisa font*
Also, it's overriden everywhere on the page cause other ligatures work like arrows
image
to be more specific, it works everywhere here, except on line 7, where ".." disappears
and as you can see this specific ligature does work on the page, just inside those specific input code blocks

@ehuss
Copy link
Contributor

ehuss commented Mar 11, 2024

Hm, I don't see anything at https://github.com/sunface/rust-by-practice/tree/master/en that indicates that the font is being overridden, and the fonts are the normal fonts when I open the given link. Are you using a local override?

Regardless, we have noted issues in the past (like #1061) where the ACE editor is sensitive to the font that is used, and the CSS was adjusted to prevent those overrides.

@Ciflire
Copy link
Author

Ciflire commented Mar 11, 2024

yeah i'm locally overriding this

@shenef
Copy link

shenef commented Mar 11, 2024

Have you tried enabling more font features?
Took a bit of searching but when you scroll down far enough, the specimens page of MonoLisa lists the font feature needed for each ligature set. For your case it seems to be SS17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants