Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include directives to missing files do not return error #1094

Open
mdboom opened this issue Nov 11, 2019 · 1 comment · May be fixed by #2277
Open

Include directives to missing files do not return error #1094

mdboom opened this issue Nov 11, 2019 · 1 comment · May be fixed by #2277
Labels
A-link-preprocessor Area: Link preprocessor, #{{include}}, etc.

Comments

@mdboom
Copy link

mdboom commented Nov 11, 2019

Our project used some include directives, that due to refactoring, inadvertently pointed to the wrong location, resulting in log error messages like the following:

[ERROR] (mdbook::preprocess::links): Error updating "{{#include ../tab_header.md}}", Could not read file for link {{#include ../tab_header.md}} (...)

These errors don't result in returning an error code from the process, so we missed them in CI.

Should these (and maybe all error log messages), result in an error code?
@mdboom mdboom mentioned this issue Nov 11, 2019
Merged
@ehuss ehuss added the A-link-preprocessor Area: Link preprocessor, #{{include}}, etc. label Apr 21, 2020
@ehuss
Copy link
Contributor

ehuss commented Apr 21, 2020

Returning an error seems reasonable to me.

@ehuss ehuss mentioned this issue Sep 22, 2022
Closed
@max-sixty max-sixty mentioned this issue Feb 20, 2023
Merged
@ziflit ziflit mentioned this issue Jul 23, 2023
Merged
@toxeus toxeus linked a pull request Dec 29, 2023 that will close this issue
Open
@conorsch conorsch mentioned this issue Apr 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-link-preprocessor Area: Link preprocessor, #{{include}}, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preprocess/links: fail for invalid links toxeus/mdBook
2 participants
@mdboom @ehuss