Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptor/Adapter Inconsistency #3824

Open
SpectralPixel opened this issue Jan 22, 2024 · 4 comments
Open

Adaptor/Adapter Inconsistency #3824

SpectralPixel opened this issue Jan 22, 2024 · 4 comments
Labels
2024-fix-nomination blocked upstream Blocked on a change that needs to happen in a different repo first Q for ourselves

Comments

@SpectralPixel
Copy link

  • I have searched open and closed issues and pull requests for duplicates, using these search terms:
    • American (desired result: something along the lines of "American/English spelling inconsistency")
    • inconsistency
    • adaptor
    • adapter
  • I have checked the latest main branch to see if this has already been fixed, in this file:

URL to the section(s) of the book with this problem:
The only appearance of this problem is in https://doc.rust-lang.org/book/ch13-02-iterators.html#using-closures-that-capture-their-environment, twice in the first paragraph of this section.

Description of the problem:
-> Throughout the page 13.2. Processing a Series of Items with Iterators the U.K. spelling "adaptor" is much more prominent than the U.S. spelling, which is "adapter". The U.S. spelling only appears twice at the beginning of the "Using Closures that Capture Their Environment".

Suggested fix:
Change those two instances from "adapter" to "adaptor".

@carols10cents
Copy link
Member

The main problem I have with this is the standard library docs use "adapter" -- https://doc.rust-lang.org/std/iter/index.html#adapters

@carols10cents
Copy link
Member

See rust-lang/rust#87629

@SpectralPixel
Copy link
Author

I see. In that case it might make more sense to replace all instances of "adaptor" (U.K.) with "adapter" (U.S.). This is a much bigger issue than I originally thought, though it shouldn't be difficult to patch up.

@carols10cents carols10cents added the blocked upstream Blocked on a change that needs to happen in a different repo first label Mar 22, 2024
@chriskrycho
Copy link
Contributor

@carols10cents it looks like this got un-blocked upstream back in 2021, so should we go ahead with flipping it for the 2024 edition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-fix-nomination blocked upstream Blocked on a change that needs to happen in a different repo first Q for ourselves
Projects
None yet
Development

No branches or pull requests

3 participants