Hi,

I’ve tried the final project in the book, and it’s really great stuff, I learned a lot. Thanks to everyone who took part in making it.

There was one thing that left me really confused though, and I’d like to make a humble suggestion. Maybe for book’s next edition, in case you agree.

In the final version, when we make 2 requests, the server goes to a shutdown. What I didn’t know, is that Chrome would randomly open TCP connections without sending any data. For example, that’s the output that made me wonder what's going on:

It looks as if server tries to go to a shut down after 1 request. Took me some digging, but as I understand it, here’s what actually happens:

1. Chrome sends GET / request and then establishes a second TCP connection without sending anything over it. That second connection’s job goes to a thread as intended.
2. Meanwhile, main thread is finished, because it registered 2 connections. Loop exits, ThreadPool goes out of scope and Drop trait is called.
3. The thread that received the second TCP connection is executing handle_connection() function where stream.read() is waiting for data to come. So until it gets data or connection closes, the thread keeps working.

You can emulate this behavior using these commands in terminal.
To open TCP connection, send an invalid HTTP request, and close connection:

echo -n | nc 127.0.0.1 7878

To open a second TCP connection and keep it until further input, which seems like what Chrome does in the example:

nc 127.0.0.1 7878

My suggestion is to add a note about this, because in previous chapters a few valuable notes were made about particularities of browsers.

Most people probably use Chrome to try it out. They will see that something weird’s going on with graceful shutdown, and Chrome devtools don’t hint there’s something else is sent apart from a single GET request.

For example, a helpful note could be:

Another interesting thing you might notice is that when you use Chrome, you can see main thread going into shutdown before you make a second request, with one last thread still working. It happens because browsers can open up a few TCP connections without sending HTTP requests (or anything) over them. Our server shuts down after 2 connections, while handle_connection() function will wait on a given TCP connection until data comes.

To test your server in a more controlled fashion, use HTTP clients like Postman or Insomnia.

Or something along those lines.

Alternatively, it could certainly be left as it is. I learned something while trying to figure it out, others might also want to. 🙂