Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with Euro sign translation in deroff.rs #16

Open
necaris opened this issue Mar 18, 2019 · 3 comments
Open

Figure out what to do with Euro sign translation in deroff.rs #16

necaris opened this issue Mar 18, 2019 · 3 comments
Labels
post-mvp Enhancement or fix to look at after we have a working port

Comments

@necaris
Copy link
Collaborator

necaris commented Mar 18, 2019

The code in deroff.py translates the "Eu" and "eu" specifications to octal 244, which is "¤" (general currency symbol) -- however, since the "Do" and "ct" specifications translate to "$" and "ct" respectively, it would seem that "€" is actually more appropriate. Thoughts?

@scooter-dangle
Copy link
Member

Yeah, the actual seems way more appropriate but maybe the original deroff has a reason for not using chars outside of Latin-1? Something to investigate more closely when we're able to do full completion generation to see if that messes with the shell completions.

@purew
Copy link
Collaborator

purew commented Mar 18, 2019

Aye, should probably first do a translation to rust that mimicks the pyhton-script completely. That way we can verify functionality with python before improving or changing the behaviour.

necaris pushed a commit that referenced this issue Mar 18, 2019
@necaris
Copy link
Collaborator Author

necaris commented Mar 18, 2019

Opened #20 to revert to the Python script behavior until we know what we want to change it to 😄

@scooter-dangle scooter-dangle added the post-mvp Enhancement or fix to look at after we have a working port label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mvp Enhancement or fix to look at after we have a working port
Projects
None yet
Development

No branches or pull requests

3 participants