Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright license is not showing on mobile devices in Saved Page #2365

Closed
3 tasks done
Rajvardhan222 opened this issue May 17, 2024 · 6 comments
Closed
3 tasks done

Copyright license is not showing on mobile devices in Saved Page #2365

Rajvardhan222 opened this issue May 17, 2024 · 6 comments
Labels
bug Something isn't working priority: medium Modifying an existing feature

Comments

@Rajvardhan222
Copy link

Rajvardhan222 commented May 17, 2024 •
edited

Description

when we visit saved tab with mobile phone "© 2024 LinksHub | MIT License
Developed by
Rupali Haldiya and Open Source Community"

this footer is not visible there

Screenshots

Screenshot 2024-05-17 174338
as you can see copy right footer is not visible even if we scroll on mobile devices.
Screenshot 2024-05-17 174353

but after changes it is visible...

Any additional information?

No response

What browser are you seeing the problem on?

No response

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
@Rajvardhan222 Rajvardhan222 added bug Something isn't working priority: medium Modifying an existing feature labels May 17, 2024
@github-actions GitHub Actions
Copy link

Hello Rajvardhan222!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@Rajvardhan222
Copy link
Author

The second image is after i made the changes

@Rajvardhan222 Rajvardhan222 mentioned this issue May 17, 2024
Closed
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Do we want to display that on mobile devices?

The team option is already there in the mobile nav.

@Rajvardhan222
Copy link
Author

Then it should be fully removed as it is visible on mobile devices very very very little and therefore i got there and thought to make it entirely visible
20240519_102636

@rupali-codes
Copy link
Owner

@rupali-codes Do we want to display that on mobile devices?

The team option is already there in the mobile nav.

Either we completely hide it or just show properly, its kinda glitching

@github-actions GitHub Actions
Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: medium Modifying an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed footer Rajvardhan222/LinksHub
3 participants
@Anmol-Baranwal @rupali-codes @Rajvardhan222