Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-specified build flags #39

Open
anttikantee opened this issue Sep 10, 2013 · 8 comments
Open

User-specified build flags #39

anttikantee opened this issue Sep 10, 2013 · 8 comments

Comments

@anttikantee
Copy link
Member

Make setting BUILDRUMP_C{,PP}FLAGS etc. in the env work as expected: extra flags passed to the compiler.

We probably need two sets of variables: one set hypervisor components and one set for kernel components.

@justincormack
Copy link
Member

Now we have the -F option. Any other requirements here?

@anttikantee
Copy link
Member Author

The intention, as far as I remember, was to take them from the env when rumpmake is run. That might just be handled with the buildconfig branch. However, -F doesn't allow separate hypervisor and kernel flags.

@justincormack
Copy link
Member

We could add a -h option to just build hypervisor and not kernel perhaps?

@anttikantee
Copy link
Member Author

I don't think it's quite that simple ;-)

The I/O related hypercalls are private to components and generally bundled with them, so some careful planning is required. I'm not quite happy with how virtif users deal with it, though it's the best way that we currently have.

@justincormack
Copy link
Member

OK, but that does leave this issue a bit vague ;-)

That reminds me I had another idea about virtif that I was going to experiment with too.

@anttikantee
Copy link
Member Author

I think that we need to come up with a list of scenarios that should work, and then modify the code based on that list. Otherwise we'll just keep modifying the code back and forth.

@justincormack
Copy link
Member

OK, well I don't know that I can think of any scenarios where it would be necessary...

@anttikantee
Copy link
Member Author

One easy example: hypercalls should use headers from -I/foo instead of /usr/include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants