Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ticket Authors to Watchers #38

Open
shawnpk opened this issue Mar 11, 2021 · 1 comment
Open

Adding Ticket Authors to Watchers #38

shawnpk opened this issue Mar 11, 2021 · 1 comment

Comments

@shawnpk
Copy link

shawnpk commented Mar 11, 2021

Chapter 11 deals with sending emails and adding watchers. Upon finishing this chapter, I noticed that we don't actually add the ticket author to the watchers. In spec/features/ticket_notifications_spec.rb, we assign 'Alice' directly to the ticket.watchers, but I don' see anywhere in the code where we actually assign the ticket author to the watchers.

I fixed this by adding @ticket.watchers << @ticket.author in the create action of the TicketsController.

This is in the version generated on 2021-02-12 from 0a83c5577 in the epub version.

@radar
Copy link
Contributor

radar commented Apr 30, 2021

You're right! This should really be added before the "Previewing emails" section in Chapter 11. I'll leave this open so we can address it next time we run through the book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants