Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "Featured pets" on the org home page #558

Closed
nsiwnf opened this issue Mar 18, 2024 · 9 comments
Closed

Display "Featured pets" on the org home page #558

nsiwnf opened this issue Mar 18, 2024 · 9 comments
Assignees
Labels

Comments

@nsiwnf
Copy link
Collaborator

nsiwnf commented Mar 18, 2024

Randomly select 4 of the org's adoptable_pets to display on the home page.
Change copy under the pet image to "Adopt [pet's name] ->" as shown below.

Screen Shot 2024-03-17 at 6 54 57 PM
@DreamVenerable
Copy link
Contributor

I can take this!

@VonTeacher
Copy link
Contributor

@DreamVenerable @nsiwnf Any progress on this? If not, I can take care of it this weekend.

@DreamVenerable
Copy link
Contributor

I got busy and totally forgot about it 😅

You are free to take it!

@VonTeacher
Copy link
Contributor

VonTeacher commented Apr 11, 2024

OK, thanks for the response. If you want, I can ping you when it's ready for review. :)

@nsiwnf, pinging for reassignment.

@kasugaijin
Copy link
Collaborator

@VonTeacher All yours!

@VonTeacher
Copy link
Contributor

I have a sample of pet cards displaying on the organization's HomeController, but I'm unsure of the best or established pattern in the repository for that query and creation of the instance variable in app/controllers/organizations/home_controller.rb, so feedback is particularly welcome.

@kasugaijin
Copy link
Collaborator

kasugaijin commented Apr 22, 2024

Can you make a draft PR with your approach? It's easier to comment on the existing code and gives you a chance to choose a solution. I see what you mean though, it's a one-off type of query that doesn't relate particularly well to any specific model, enough to put on a model for example.

Edit: I took a look at your PR and think the approach is fine. Review to follow!

@nsiwnf nsiwnf linked a pull request May 6, 2024 that will close this issue
2 tasks
@kasugaijin
Copy link
Collaborator

@VonTeacher I will unassign so someone else can finish this off. But, let me know if you want to finish it!

Just a couple comments to address in the PR (delete some tests). It should be a quick fix. #660

@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label May 17, 2024
@meg-gutshall meg-gutshall self-assigned this May 31, 2024
@maebeale maebeale added Assigned and removed Ready Make a comment to get assigned. labels May 31, 2024
@meg-gutshall
Copy link
Member

Closed by #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants