-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display "Featured pets" on the org home page #558
Comments
I can take this! |
@DreamVenerable @nsiwnf Any progress on this? If not, I can take care of it this weekend. |
I got busy and totally forgot about it 😅 You are free to take it! |
OK, thanks for the response. If you want, I can ping you when it's ready for review. :) @nsiwnf, pinging for reassignment. |
@VonTeacher All yours! |
I have a sample of pet cards displaying on the organization's HomeController, but I'm unsure of the best or established pattern in the repository for that query and creation of the instance variable in |
Can you make a draft PR with your approach? It's easier to comment on the existing code and gives you a chance to choose a solution. I see what you mean though, it's a one-off type of query that doesn't relate particularly well to any specific model, enough to put on a model for example. Edit: I took a look at your PR and think the approach is fine. Review to follow! |
@VonTeacher I will unassign so someone else can finish this off. But, let me know if you want to finish it! Just a couple comments to address in the PR (delete some tests). It should be a quick fix. #660 |
Closed by #784 |
Randomly select 4 of the org's adoptable_pets to display on the home page.
Change copy under the pet image to "Adopt [pet's name] ->" as shown below.
The text was updated successfully, but these errors were encountered: