Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mobile view for Staff "Review Applications" #547

Open
3 tasks done
nsiwnf opened this issue Mar 13, 2024 · 2 comments · May be fixed by #802
Open
3 tasks done

Fix: Mobile view for Staff "Review Applications" #547

nsiwnf opened this issue Mar 13, 2024 · 2 comments · May be fixed by #802
Assignees
Labels
Assigned bug 🐞 Something isn't working

Comments

@nsiwnf
Copy link
Collaborator

nsiwnf commented Mar 13, 2024

Some of the buttons disappear in mobile view on the staff's "adoption applications" dashboard page. There is also no way for staff to edit notes and "create adoption" on mobile devices.

  1. go to demo site
  2. login as staff
    email: staff@alta.com
    password: 123456
  3. go to "Adoption Applications" tab in the navbar
Screen Shot 2024-03-12 at 10 05 24 PM

We should style the content so it renders as cards below 1200 px width. Use /staff/manage_fosters as a guide. It would probably be good to do something similar to this:

<!-- app/views/organizations/staff/manage_fosters/index.html.erb -->
        <!-- Search Results -->
        <%# Table layout %>
        <div class="d-none d-xl-block">
          <%= render "foster_table", foster_pets: @foster_pets %>
        </div>

        <%# Cards layout %>
        <div class="d-xl-none d-flex flex-wrap">
          <%= render "foster_cards", foster_pets: @foster_pets %>
        </div>

Acceptance Criteria

  • Page index content renders cards below 1200 px width
  • All card content fits on mobile screens
  • Applications should be grouped by pet still (again, see /staff/manage_fosters design)
@nsiwnf nsiwnf added bug 🐞 Something isn't working needs design Needs UI/UX designer input labels Mar 13, 2024
@kasugaijin
Copy link
Collaborator

Just some thoughts for when this is being designed. We could use a table layout like we currently have for larger widths, and for narrower widths, we get rid of the table and instead use cards. I think tables are inherently better consumed on larger screens, and cards are better for smaller screens. My two cents!

@MooseCowBear
Copy link
Contributor

Might also want to consider the applications tab on the pets show page, which uses the same partial. Currently there is some overlap there to resolve.
Screenshot 2024-05-03 at 4 51 15 PM

@mononoken mononoken added Ready Make a comment to get assigned. and removed needs design Needs UI/UX designer input labels May 29, 2024
@jmilljr24 jmilljr24 self-assigned this May 31, 2024
@jmilljr24 jmilljr24 added Assigned and removed Ready Make a comment to get assigned. labels May 31, 2024
@jameybash jameybash self-assigned this Jun 1, 2024
@jmilljr24 jmilljr24 linked a pull request Jun 3, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants