Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message for "Quantity is not a number" to "Quantity is not a number -- note: commas are not allowed." #4310

Open
3 tasks
cielf opened this issue Apr 28, 2024 · 4 comments · May be fixed by #4412
Open
3 tasks
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 28, 2024

Summary

Provide more detail on "Quantity is not a number" error on Itemizables

Why?

This error specifically excludes values like "1,300" -- the comma is not allowed. But people who enter numbers with commas will expect them to be considered numbers. We need to explain better.

Details

Change the "Quantity is not a number" error on Itemizable to "Quantity is not a number . Note: commas are not allowed"

Criteria for completion

  • text changed
  • tests around quantity still work
  • please provide a screenshot of the error in action
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Apr 28, 2024
@mikjmcc26
Copy link

I'd like to take this if available!

@cielf
Copy link
Collaborator Author

cielf commented Apr 29, 2024

It's yours!

@mikjmcc26 mikjmcc26 removed their assignment May 19, 2024
@vsrnth
Copy link
Contributor

vsrnth commented May 23, 2024

Can I pick this up?

@dorner
Copy link
Collaborator

dorner commented May 23, 2024

Yes!

@vsrnth vsrnth linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
4 participants