Include period supplies in kits in NDBN report values that are based on period supplies

[cielf]

Summary

Period supply values in the Annual Survey should include period supplies in kits

Why?

Better reporting of actual distribution

Details

Similar to issue #3939... You may need to use SQL to extract the information
Look at services/reports/period_supply_report_service
Assume 1 kit per individual

The following values in the report will need attention:
Period Supplies distributed
Period Supplies per adult per month [Note: this should be per individual per month -- confirmed with NDBN liason]
% period supplies donated -- note that most banks make their own kits, but we do have some who have kits donated -- so this is a slightly different twist from #3939
% period supplies bought -- afaik, we don't have any cases of kits being bought, but we don't prevent it.

Criteria for completion

• values in report regarding period supplies reflect period supplies in kits
• tesets demonstrating the changes

[cielf]

This is going to be assigned to @jadekstewart3. This comments just here so I can do that. Apparently I actually need Jade to comment on this issue to do that!

[jadekstewart3]

I can take this! Thank you :)

[cielf]

Thank you!

[jadekstewart3]

Just an update: Still working on this. I was OOO the last week an a half, so I am hoping to get some more done this week and next :)

[cielf]

Hi @jadekstewart3 -- just a heads up that I'm doing some rework of the whole what-goes-in-what-bucket due to conversations with NDBN, and things I've found that were just not right! keep an eye on PR # 4361.
There is going to be a rework of what is in period_supplies -- making it depend on the category rather than the partner keys --- it turns out the initialization of the seed and what is in prod had different categories, which explains why someone coded it with the partner keys! The latest on that should (I hope) be up later today, though not merged.