Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling on New Item #4274

Closed
2 tasks
cielf opened this issue Apr 14, 2024 · 6 comments · Fixed by #4374
Closed
2 tasks

Improve error handling on New Item #4274

cielf opened this issue Apr 14, 2024 · 6 comments · Fixed by #4374
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced stale

Comments

@cielf
Copy link
Collaborator

cielf commented Apr 14, 2024

Summary

If you are entering a new item, and you use the name of an existing item, the message should be helpful.

Why Fix

Reduce bank confusion, support time.

Details

This happened when a bank tried to enter a new item and used the name of an inactive item.
All they got was a "Something Didn't Quite Work Right - Try Again?" message.
In this case, the error messages should include "An Item with that name already exists (could be an inactive item). "

Criteria for Completion

  • If you try to enter an item with the same name as an existing item, you receive the more helpful message
  • tests to demonstrate this behaviour
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Apr 14, 2024
@Gabe-Torres
Copy link
Contributor

Would love to take this one

@dorner
Copy link
Collaborator

dorner commented Apr 15, 2024

Give it a shot!

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@Gabe-Torres
Copy link
Contributor

Hey @cielf and @dorner! I created a new pr for this issue and closed the previous one.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented May 29, 2024

PR is under review. Keeping the assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced stale
Projects
None yet
3 participants