Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds delivery address to distribution printout/receipt #4164

Merged

Conversation

kannans5
Copy link
Contributor

@kannans5 kannans5 commented Mar 6, 2024

Resolves #4138

Description

Adds delivery address to distribution printout/receipt

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Login in as user_1@example.com.
  2. Go to distributions
  3. Print any distribution
  4. The pdf should have Delivery address: added to the left. (if delivery method is shipped or delivered)

Note: I did not find any existing unit test or browser test related to distribution pdf. If someone could point me to the relevant tests, I am happy to cover this scenario.

Screenshots

If the distribution delivery method is either shipped or delivered, the print will look like this

Screenshot 2024-03-05 at 10 26 02 PM

If not no change in the receipt.

Screenshot 2024-03-02 at 10 28 46 PM

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kannans5 - this looks pretty good, but it's missing one of the requirements:

Change the prompt for program address on the partner to "Program / delivery address (if different)"

@kannans5
Copy link
Contributor Author

@dorner where exactly this is shown (on the pdf?) or inside the app?

Change the prompt for program address on the partner to "Program / delivery address (if different)"

@cielf
Copy link
Collaborator

cielf commented Mar 12, 2024

If you sign in as verified@example.com, click edit my organization -- there is a Program Address (if different) in that screen, which needs to be changed. Also, if you click "My organization", which is the corresponding view.

These are also accessed from the bank side, though the partner agencies, then clicking on the specific partner 'edit" or "view', but I'm pretty sure they use the same partials.

@kannans5 kannans5 force-pushed the 4138-adds-delivery-addr-to-distr-printout branch from cd02ffd to 94d8a15 Compare March 12, 2024 16:58
@kannans5
Copy link
Contributor Author

I changed at these 3 places:

Screenshot 2024-03-12 at 10 26 34 PM
2.
Screenshot 2024-03-12 at 10 25 36 PM
3.
Screenshot 2024-03-12 at 10 25 01 PM

@kannans5
Copy link
Contributor Author

If you sign in as verified@example.com, click edit my organization -- there is a Program Address (if different) in that screen, which needs to be changed. Also, if you click "My organization", which is the corresponding view.

These are also accessed from the bank side, though the partner agencies, then clicking on the specific partner 'edit" or "view', but I'm pretty sure they use the same partials.

Let me know if these are the changes we are looking for.

@cielf
Copy link
Collaborator

cielf commented Mar 13, 2024

Looks like it to me.

@kannans5 kannans5 requested a review from dorner March 13, 2024 16:43
@dorner
Copy link
Collaborator

dorner commented Mar 13, 2024

Looks good to me too. Thanks!

@dorner dorner merged commit c62638b into rubyforgood:main Mar 13, 2024
19 checks passed
@kannans5 kannans5 deleted the 4138-adds-delivery-addr-to-distr-printout branch March 16, 2024 02:09
@cielf
Copy link
Collaborator

cielf commented Mar 16, 2024

Hrm. When I did the pre-release test of this on staging, on a delivery distribution, I didn't get a delivery address printing out. I'm not going to hold the release on this, but something is not working properly.

Copy link
Contributor

@kannans5: Your PR Adds delivery address to distribution printout/receipt is part of today's Human Essentials production release: 2024.03.17.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delivery address to distribution "receipt"
3 participants