Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array and hash max stack optimizations #2400

Open
kddnewton opened this issue Feb 13, 2024 · 0 comments
Open

Use array and hash max stack optimizations #2400

kddnewton opened this issue Feb 13, 2024 · 0 comments
Labels
compiler enhancement New feature or request
Milestone

Comments

@kddnewton
Copy link
Collaborator

kddnewton commented Feb 13, 2024

When constructing a dynamic array or hash in CRuby, everything in pushed onto the stack and then newarray/newhash is called. In the existing CRuby compiler, there are optimizations in place when the number of elements is very large where it will group the elements so not too many values are pushed onto the stack at any given point. We've skipped this optimization, but we'll need it to say we're 1:1.

ruby/ruby#9766

@kddnewton kddnewton added enhancement New feature or request compiler labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant