Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the embedly-ruby gem is installed, the Embedly provider should use it to make ruby-oembed more awesome! #8

Open
metavida opened this issue Feb 11, 2011 · 0 comments
Labels

Comments

@metavida
Copy link
Collaborator

The ruby-oembed gem doesn't have to be in competition with Embedly's embedly-ruby gem. If the embedly-ruby gem is loaded, ruby-oembed should detect it and use a specialized OEmbed::Providers::Embedly Class that uses the embedly-ruby gem internally. There are several advantages to this setup.

  1. Because we use the embedly-ruby gem the list of supported URLs will never be out of date.
  2. Because we use ruby-oembed calling OEmbed::Providers.get can resolve oEmbed URLs that aren't registered with Embedly (perhaps because they're private) along side every other oEmbed URL that is supported by Embedly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant