Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedly deprecating free tier #66

Open
vietqhoang opened this issue Mar 16, 2017 · 5 comments
Open

Embedly deprecating free tier #66

vietqhoang opened this issue Mar 16, 2017 · 5 comments

Comments

@vietqhoang
Copy link

vietqhoang commented Mar 16, 2017

Embedly is removing the free tier for their API.

What is the opinion of this library in regards to paid aggregators? The library heavily relies on Embedly and the deadline for their API transition is April 17th.

The announcement can be found here.

@metavida
Copy link
Collaborator

That's disappointing! You have a few options with this library:

  1. If you decide to pay for Embedly, you can add your API key to the Embedly object: OEmbed::Providers::Embedly.endpoint += "?key=#{my_embedly_key}"
  2. If it's acceptable to lose support for some of the sites that Embedly had added custom support for, you can use the built-in providers and provider discovery in this gem to maintain decent free functionality :
OEmbed::Providers.register_all
OEmbed::Providers.register_fallback(OEmbed::ProviderDiscovery)

@metavida
Copy link
Collaborator

I've also been meaning to create an official provider for https://noembed.com/ so I suppose this would be a great time to make that happen 😃

@metavida
Copy link
Collaborator

With ruby-oembed 0.12.0 (released today) you can now use the built-in Noembed provider as a direct replacement for the built-in Embedly provider.

OEmbed::Providers.register_all
OEmbed::Providers.register_fallback(OEmbed::Providers::Noembed, OEmbed::ProviderDiscovery)

@vietqhoang
Copy link
Author

Thanks for the hard work!

@metavida
Copy link
Collaborator

metavida commented Dec 28, 2020

A new comment on this very-old thread, because once Pull #78 is released, it will now be possible to add the Embedly key to the built-in provider's required_query_params list.

Advantages

This would allow people to inject their Embedly key using either an environment variable:

ENV['OEMBED_EMBEDLY_KEY'] #=> 'your key'
OEmbed::Providers.register_fallback(OEmbed::Providers::Embedly)

or using a setter:

OEmbed::Providers::Embedly.key = @your_key
OEmbed::Providers.register_fallback(OEmbed::Providers::Embedly)

It will also save folks some confusion by preventing the provider from sending requests to Embedly without a key being set.

Breaking Change!

However, updating the built-in provider to use the required_query_params feature means that folks using the OEmbed::Providers::Embedly.endpoint += "?key=#{my_embedly_key}" work-around must change their code to use one of the new methods of setting their key. Unless I figure out some provider-specific method of detecting a key being injected into the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants