Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage using it_should_behave_like and friends #69

Open
pirj opened this issue Nov 23, 2018 · 3 comments
Open

Discourage using it_should_behave_like and friends #69

pirj opened this issue Nov 23, 2018 · 3 comments
Assignees

Comments

@pirj
Copy link
Member

pirj commented Nov 23, 2018

There's a number of methods that have modern counterparts, recommend using the new ones instead.

@pirj pirj self-assigned this Feb 5, 2019
@andyw8
Copy link
Contributor

andyw8 commented Apr 28, 2019

For reference, here's where this was added: rspec/rspec-core@7b0d232

@imajes
Copy link

imajes commented Apr 7, 2021

Why? I don't see why this requires a cop. It's perfectly fine to have readable code sentences, which is why there's first-class support for aliases in rspec.

@pirj
Copy link
Member Author

pirj commented Apr 7, 2021

Basically because "should" syntax is being removed from RSpec, along with all references to it. See https://github.com/rspec/rspec-core/pull/2864/files#diff-8c60417422cf21f6d3abdc5b63d992eee058c43039601cc0cee1d7111db85420L1133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants