Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Logger #215

Open
ennerperez opened this issue Jul 1, 2023 · 2 comments
Open

Replace Logger #215

ennerperez opened this issue Jul 1, 2023 · 2 comments

Comments

@ennerperez
Copy link
Contributor

In order to simplify logger, can be a good enhancement if project use Serilog as base for all logs, all current logger functionality can be covered using serilog enrichments.

Solution: Replace CompilePalLogger with a clasic Serilog Implementation

Alternatives: NLog, Log4Net

@Exactol
Copy link
Collaborator

Exactol commented Jul 8, 2023

If I was going to start from scratch then I agree that a logging library would make more sense, but since the logger doesn't change often I don't really see how it would be beneficial

@ennerperez
Copy link
Contributor Author

I understand, it just an enhancement, also I think is a good start to decoupling the dependencies in the project, avoid using a custom logger for something more flexible, CompilePalLogger is too strict to be extended, also doesn't follow the ILogger interface.

Using a custom logging library like Serilog, can enhance the way how the app writes logs, making it async, structured, standard and extensible for future developments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants