Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sensors for rotating radar view doesn't work on some devices #99

Open
EugenGez opened this issue Sep 2, 2022 · 2 comments
Open

Comments

@EugenGez
Copy link

EugenGez commented Sep 2, 2022

Hi together.

The following issue applies for Samsung Galaxy A3 2016 / SM-A310F / Android 7.0

When "Use sensors to rotate radar view" is active, then the red cross is only showed at azimuth: 0°, elevation: 0°. I successfully tested the sensors with other apps like HamGPS, so they are working properly.

On some other smartphones, including Samsung Galaxy J7 / SM-J730F / Android 9, this feature works correctly.

ADD:
And it probably make sense to implement some kind of smoothing for sensors. On some devices the radar view jumps around a little bit: Samsung Galaxy J7 / SM-J730F / Android 9

Thanks

@rt-bishop
Copy link
Owner

Hey @EugenGez, thanks for reporting this issue!

Look4Sat is currently using the google recommended sensor-fusion way of getting the data from the phone's sensors. The old legacy way is using the accelerometer and gyroscope which may be missing on certain phone models. Also AFAIK Samsung tends to change the default behaviour of certain system components which may lead to this issue when sensor-fusion works on some phones and does not on the others.

I'm not sure that switching back to acc/gyro is a good idea because it can lead to the same behaviour on the other users phones, let's say working on your devices but stopping to work on theirs. I can definitely experiment with this at some stage, potentially releasing it and then reverting if I start receiving complains.
The other problem is that I don't have any Samsung devices that I can test on, so even this fix may not work for you Samsung if the company altered the SensorManager behaviour or the sensor name.

@EugenGez
Copy link
Author

EugenGez commented Sep 2, 2022

Hi @rt-bishop,

Maybe it would be possible to implement both ways to additionally support older devices as well? The decision about how to access the sensors could then be made by the application itself at start time or even by the user in the settings.

I'm a developer too and I know, it could be much work, since You most probably would need to implement an abstraction layer for that two access ways, which also could cause new bugs etc. But hey, on the other side, I think many HAMs are not in that age anymore, that they always buy the newest smartphone. 🤣

I think it would be helpful for many users.

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants