Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all Tree related components. #3769

Merged
merged 29 commits into from May 15, 2024
Merged

Refactor all Tree related components. #3769

merged 29 commits into from May 15, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Apr 25, 2024 •
edited

Refactor components

  • Refactor CheckTree
  • Refactor CheckTreePicker
  • Refactor Tree
  • Refactor TreePicker

Features

  • feat: add support for searchable on <Tree> and <CheckTree>.

Bug Fixes

BREAKING CHANGE 🚨

In TreePicker and CheckTreePicker components, the following props have been deprecated and replaced with new props:

Deprecated props New props
menuClassName popupClassName
menuStyle popupStyle
renderMenu renderTree
height treeHeight

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:48am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:48am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 7:48am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 25, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited

Codecov Report

Attention: Patch coverage is 90.73227% with 162 lines in your changes are missing coverage. Please review.

Project coverage is 94.21%. Comparing base (a5c5f0c) to head (062c8ab).
Report is 27 commits behind head on main.

Files Patch % Lines
src/Tree/hooks/useTreeDrag.ts 52.50% 52 Missing and 5 partials ⚠️
src/Tree/utils/focusableTree.ts 75.80% 8 Missing and 7 partials ⚠️
src/Tree/hooks/useFocusTree.ts 77.77% 6 Missing and 8 partials ⚠️
src/CheckTree/CheckTreeView.tsx 87.77% 6 Missing and 5 partials ⚠️
src/Tree/TreeView.tsx 89.28% 6 Missing and 3 partials ⚠️
src/Tree/hooks/useTreeNodeProps.ts 68.00% 7 Missing and 1 partial ⚠️
src/CheckTree/hooks/useTreeCheckState.ts 85.10% 2 Missing and 5 partials ⚠️
src/Tree/utils/treeKeyboardInteractions.ts 61.53% 3 Missing and 2 partials ⚠️
src/CheckTree/utils.ts 78.94% 2 Missing and 2 partials ⚠️
src/Tree/TreeNodeToggle.tsx 69.23% 2 Missing and 2 partials ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3769      +/-   ##
==========================================
+ Coverage   93.77%   94.21%   +0.43%     
==========================================
  Files         655      698      +43     
  Lines       22631    23207     +576     
  Branches     3081     3094      +13     
==========================================
+ Hits        21222    21864     +642     
+ Misses        720      673      -47     
+ Partials      689      670      -19
Flag Coverage Δ
ChromeCi 94.16% <90.73%> (+0.45%) ⬆️
Firefox 93.57% <90.56%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo marked this pull request as ready for review April 29, 2024 11:35
@simonguo
Copy link
Member Author

simonguo commented May 9, 2024

@superman66 前面提到的3 个问题已修复。

@simonguo simonguo merged commit 2650886 into main May 15, 2024
15 of 16 checks passed
@simonguo simonguo deleted the refactor/tree branch May 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superman66 superman66 superman66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@simonguo @superman66