Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow NULL menu items in the UI #362

Open
daattali opened this issue Feb 12, 2021 · 2 comments
Open

Feature request: allow NULL menu items in the UI #362

daattali opened this issue Feb 12, 2021 · 2 comments

Comments

@daattali
Copy link

This comes up when you want to include a conditional.

For example

library(shiny)
library(shinydashboard)

show_tab_2 <- FALSE

ui <- dashboardPage(
  dashboardHeader(),
  dashboardSidebar(
    sidebarMenu(
      menuItem("tab1", tabName = "tab1"),
      if (show_tab_2) menuItem("tab2", tabName = "tab2")
    )
  ),
  dashboardBody(
    tabItems(
      tabItem("tab1", "tab1"),
      if (show_tab_2) tabItem("tab2", "tab2")
    )
  )
)
server <- function(input, output) {}
shinyApp(ui, server)

This results in an error since the if statement results in a NULL ui item. It would be useful if shinydashboard knew to just ignore NULL items

@daattali
Copy link
Author

The problems seems to be with the tabItems() rather than sidebarMenu()

@ismirsehregal
Copy link

This would be useful!

For those interested in a workaround:

library(shiny)
library(shinydashboard)

show_tab_2 <- FALSE

ui <- dashboardPage(
  dashboardHeader(),
  dashboardSidebar(
    sidebarMenu(
      menuItem("tab1", tabName = "tab1"),
      if (show_tab_2){menuItem("tab2", tabName = "tab2")}
    )
  ),
  dashboardBody(
    tabItems(
      tabItem("tab1", "tab1"),
      if (show_tab_2){tabItem("tab2", "tab2")} else {
        div(class = 'tab-pane')
      }
    )
  )
)
server <- function(input, output) {}
shinyApp(ui, server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants