Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow-custom-resources and workbench jobs #479

Open
murraj opened this issue Mar 8, 2024 · 1 comment
Open

allow-custom-resources and workbench jobs #479

murraj opened this issue Mar 8, 2024 · 1 comment
Labels

Comments

@murraj
Copy link

murraj commented Mar 8, 2024

Are there any known issues with not allowing allow-custom-resources (allow-custom-resources=0) and workbench jobs? If I turn it on, the UI seems to respect it. However user cannot kick off workbench job.

We are running workbench in AKS. We are using the same cluster to dispatch workbench jobs. I noticed that if I attempt to set allow-custom-resources: 0 in the helm chart, we get the "Cannot start job" error when attempting to kick off a workbench job. However, if I remove allow-custom-resources (or set allow-custom-resources: 1), it works properly.

Ideally, I would only like to allow an admin (or superuser) to run something on a custom resource. However, I can live without this is there is a known issue.

Here is the section (that works) if I comment out the offending statements. The 'xxx' are entries I want to keep private:

profiles:
    launcher.kubernetes.profiles.conf:
      "*":
        default-cpus: 1
        default-mem-mb: 512
        container-images:
          - "xxx"
          - "xxx"
          - "xxx"
        default-container-image: "xxx"
        allow-unknown-images: 0 # Whether to allow users to bring their own image
        job-json-overrides:
          - target: "/spec/template/metadata/annotations/cluster-autoscaler.kubernetes.io~1safe-to-evict"
            json: "false"
            name: evict-annotation
        resource-profiles: A-ExtraSmall,B-Small,C-Medium
        # allow-custom-resources: 0
      "@superuser":
        resource-profiles: A-ExtraSmall,B-Small,C-Medium,D-Large,E-ExtraLarge
        # allow-custom-resources: 1
      "@admin":
        resource-profiles: A-ExtraSmall,B-Small,C-Medium,D-Large,E-ExtraLarge,F-Risk
        # allow-custom-resources: 1

Thanks!

@colearendt
Copy link
Member

Howdy @murraj ! Thanks so much for reporting this. And thanks for your patience. This definitely feels like an issue / oversight in the product - I will pass this message along internally to see if we can reproduce it!

@colearendt colearendt added the rsw label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants