Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pythonpublish.yml #1167

Closed
wants to merge 1 commit into from
Closed

Conversation

sigma67
Copy link

@sigma67 sigma67 commented May 31, 2023

Note: This requires a GitHub secret PYPI_API_TOKEN, which is up to the maintainers to configure.

This publishes to PyPi whenever a release is created, based on the Git tag associated with that release.

Closes #1154

@akrabat
Copy link
Member

akrabat commented Aug 3, 2023

Thanks for this. I need to work out how to fit this into the rest of our release process, so won't be merging very quickly. I really do appreciate the leg-work here though.

@akrabat akrabat self-requested a review August 3, 2023 08:05
@FriedrichFroebel
Copy link

Just as a heads-up: PyPI nowadays recommends using Trusted Publishers instead of token-based authentication: https://docs.pypi.org/trusted-publishers/using-a-publisher/

@sigma67
Copy link
Author

sigma67 commented Apr 26, 2024

Yes, there have been changes in the meantime. I can update it, but I'm not sure there's interest from the maintainers since none of my PRs got through

@lornajane
Copy link
Contributor

Thanks @FriedrichFroebel, the extra information is always appreciated.

@sigma67 the maintainers are volunteers with a large number of other commitments and limited Python expertise. We do appreciate your input in the project, but I do not find your remark about a lack of interest either constructive or helpful.

@sigma67
Copy link
Author

sigma67 commented Apr 29, 2024

@lornajane I am in the same position as an OSS maintainer myself with a full time job. Yet I manage to respond to PRs within weeks at the latest

I have submitted two PRs to this project and neither have received feedback within the past 12 months

I realize you may have more important issues on the table, but responding as you did after all this time is disrespectful of the contribution itself, honestly. Not surprised there are no external contributors other than the maintainers

If you do not want contributions, please say so - for now I will close this.

@sigma67 sigma67 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish to PyPI using a GH action
4 participants