adds jcstress for requester and responder operators #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
enhancement/jcstresstests
branch
from
18c96b4
to
de54cfd
Compare
rstoyanchev
requested changes
Apr 1, 2021
| @@ -186,6 +192,7 @@ public T block(@Nullable Duration timeout) { | |||
| @SuppressWarnings("unchecked") | |||
| final void terminate(Throwable t) { | |||
| if (isDisposed()) { | |||
| Operators.onErrorDropped(t, Context.empty()); | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Also update the copy in loadbalance?
| import reactor.core.publisher.Operators; | ||
| import reactor.util.context.Context; | ||
|
|
||
| public class StressSubscriber<T> implements CoreSubscriber<T> { |
There was a problem hiding this comment.
StressTestSubscriber perhaps?
| import reactor.core.CoreSubscriber; | ||
| import reactor.core.publisher.Operators; | ||
|
|
||
| public class StressSubscription<T> implements Subscription { |
There was a problem hiding this comment.
Likewise StressTestSubscription
Comment on lines
61
to
82
| public volatile boolean concurrentOnNext; | ||
|
|
||
| public volatile boolean concurrentOnError; | ||
|
|
||
| public volatile boolean concurrentOnComplete; | ||
|
|
||
| public volatile boolean concurrentOnSubscribe; |
There was a problem hiding this comment.
These are set but not used. Am I missing something? There are others that are not used as well like droppedErrors, onNextDiscarded, and error.
There was a problem hiding this comment.
it is ported from reactor-core and should be used in the upcoming updates
OlegDokuka
force-pushed
the
enhancement/jcstresstests
branch
7 times, most recently
from
893b7ea
to
3296d72
Compare
OlegDokuka
force-pushed
the
enhancement/jcstresstests
branch
4 times, most recently
from
20ad9dc
to
c81c408
Compare
OlegDokuka
changed the title
8 tasks
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
OlegDokuka
force-pushed
the
enhancement/jcstresstests
branch
from
c81c408
to
61cf1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JCStressTests Support
Motivation:
JCStress is a proven tool for making sure correctness of concurrency model used in various places
Modifications:
Adds list of JCStress tests
Result:
Better verification of concurrency related issues
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com