Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink behaviour when minimum is unspecified in cell_rows() and cell_cols() #27

Open
jennybc opened this issue Apr 14, 2017 · 1 comment
Milestone

Comments

@jennybc
Copy link
Member

jennybc commented Apr 14, 2017

cellranger::cell_rows(c(5, NA))
#> <cell_limits (5, -) x (-, -)>
cellranger::cell_rows(c(NA, 5))
#> <cell_limits (1, -) x (5, -)>

I'm not sure this lack of symmetry makes sense. Why does c(5, NA) mean '5 and up' (or whatever the caller wants it to mean) but c(NA, 5)means '1 through 5'?

Specifically for readxl, it seems like we should be discovering the lower limit from the data if the minimum is unspecified.

@jennybc
Copy link
Member Author

jennybc commented Apr 3, 2018

I'm not sure what the answer is, but I will resolve this before next release.

@jennybc jennybc added this to the v1.2.0 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant