Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pricing into a trait #70

Closed
rruckley opened this issue Mar 26, 2024 · 4 comments · Fixed by #133
Closed

Refactor pricing into a trait #70

rruckley opened this issue Mar 26, 2024 · 4 comments · Fixed by #133
Assignees
@rruckley
Labels
Refactor
Milestone
0.1.16

Comments

@rruckley
Copy link
Owner

TMF648 has QuotePrice and TMF663 has CartPrice.

Both of these structures have similar requirements, including tax free and tax inc pricing and associated functions.

This should be refactored to pull this into a Trait that is then implemented by both structs.

Further tmflib-macro can be updated to provide default implementation of the trait functions.
@rruckley rruckley added this to the 0.1.12 milestone Mar 26, 2024
@rruckley
Copy link
Owner Author

@ignazio-castrogiovanni Something worth looking at perhaps?

@ignazio-castrogiovanni
Copy link
Collaborator

I can't see TMF663 CartPrice in master. Is it still to be implemented? Where can I look at the specifics?

@rruckley
Copy link
Owner Author

I can't see TMF663 CartPrice in master. Is it still to be implemented? Where can I look at the specifics?

It's still in a PR, I was working on conversion between ShoppingCart and a product order when I noticed the refactor.

@rruckley
Copy link
Owner Author

rruckley commented Apr 8, 2024

@ignazio-castrogiovanni Happy to take you though my approach for this.

@rruckley rruckley modified the milestones: 0.1.12, 0.1.13 Apr 14, 2024
@rruckley rruckley modified the milestones: 0.1.13, 0.1.14 Apr 28, 2024
@rruckley rruckley modified the milestones: 0.1.14, 0.1.15 May 7, 2024
@rruckley rruckley modified the milestones: 0.1.15, 0.1.16 May 21, 2024
@rruckley rruckley linked a pull request Jun 6, 2024 that will close this issue
Common Pricing Module #133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rruckley rruckley

Labels
Refactor
Projects
None yet
Milestone
0.1.16
Development

Successfully merging a pull request may close this issue.

Common Pricing Module rruckley/tmflib
2 participants
@rruckley @ignazio-castrogiovanni