Missing sync call in nio backend

[rmannibucau]

Hi,

I think NioBackend should get a sync call even if the future is not set in close otherwise I'm not sure how a readOnly=false instance should sync itself.

Shouldn't it be:

@Override
public synchronized void close() throws IOException {
    // cancel synchronization
    try {
        if (syncRunnableHandle != null) {
            syncRunnableHandle.cancel(false);
            syncRunnableHandle = null;
        }
        if (!readOnly) {
            sync();
        }
        unmapFile();
    } finally {
        file.close();
        super.close();
    }
}

?

Romain

[fbacchella]

sync is not called when the syncRunnableHandle is not provided, because it means the user trusts the OS to do what is needed to flush the data in an enough secure way. So no special care is done in that case.