Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_* metrics #28

Open
errordeveloper opened this issue Jun 15, 2017 · 3 comments
Open

http_* metrics #28

errordeveloper opened this issue Jun 15, 2017 · 3 comments

Comments

@errordeveloper
Copy link

It seems like the metrics exposed right now do not adhere to best-practice. I'd like to discuss this before proposing any changes :)
@errordeveloper
Copy link
Author

Ok, just reviewed my findings from earlier on, and I think the only odd thing is the unit of time – some of my colleagues insist that _seconds should be used instead of _miliseconds, but I don't think there is an agreement on this in the wider community... Let's discuss, may be we could make the unit configurable?

@errordeveloper errordeveloper changed the title metric names http_* metrics Jun 15, 2017
@errordeveloper
Copy link
Author

@tcolgate @Olical renamed this to *_seconds in their fork.

@roylines
Copy link
Owner

Happy to take a pull request on this. Please follow these guidelines if you do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@errordeveloper @roylines