Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No issue just a question. #37

Open
PodeCaradox opened this issue Jul 24, 2020 · 3 comments
Open

No issue just a question. #37

PodeCaradox opened this issue Jul 24, 2020 · 3 comments

Comments

@PodeCaradox
Copy link

Hello,

first of all thanks for sharing your AStar implementation on github. Can you answer me why you also have a
IList Incoming { get; }
in your INode interface, maybe i missing something in the Code?
From your implementation of the AStar i see you only use the Outgoing List for the algorithm, which is self explained.

@roy-t
Copy link
Owner

roy-t commented Jul 24, 2020

Hey,

Good observation. the incoming list is not used when calculating the path. But it makes it a lot easier to increase the traversal time to reach a specific node. Otherwise you would need another lookup structure to find all edges going to a specific node.

I guess this technically means that it doesn't have to be part of the INode interface! (I could leave it on the concrete Node class that implements INode. Which I didn't realize before.

@roy-t
Copy link
Owner

roy-t commented Aug 2, 2020

I'll keep this question open for now, to potentially address it in potential v4, as its a breaking change to remove these members.

@PodeCaradox
Copy link
Author

Yeah that's fine, i will use your implementations in a different way for my Grid. The MinHeap is really nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants