Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable topic value telemetry and add data logging #37

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

codeflight1
Copy link

@codeflight1 codeflight1 commented Feb 11, 2023

This PR contains small changes to allow working with the latest version of openmct, and fixes the viewing of topic value telemetry. It also adds data logging with QuestDB.

Closes #13, closes #14, closes #20, closes #22, closes #31, closes #36.

@codeflight1 codeflight1 changed the title Update and enable topic value telemetry Enable topic value telemetry and add data logging Mar 18, 2023
@codeflight1 codeflight1 marked this pull request as ready for review March 18, 2023 04:46
@Ronoman
Copy link

Ronoman commented Mar 29, 2023

What is the QuestDB schema you are using? I'm struggling to guess at what it is to set this up locally.

@codeflight1
Copy link
Author

Ah sorry about that, I'll push documentation tonight.

@Ronoman
Copy link

Ronoman commented Mar 29, 2023

Would it also be possible to separate this PR into two, one for Quest DB integration and one for updating to the newer version of openmct? If QuestDB is needed for the other features then it might not be possible, but if it's really 2 separate features, I'd love to be able to test each independently.

@codeflight1
Copy link
Author

I added support for disabling the DB with the DISABLE_QUESTDB environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment